External prod stylesheet #1161
Merged
External prod stylesheet #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidsoup
reviewed
May 27, 2020
package.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| "build-ui": "cd ui && yarn install && yarn build", | |||
| "cypress-open": "cd proxy && yarn cypress-open", | |||
| "cypress-run": "cd proxy && yarn cypress-run", | |||
| "copy-build": "mkdir -p build && cp -R root/dist/* build/ && cp -R legacy/dist/assets build/", | |||
| "copy-build": "mkdir -p build && cp -R root/dist/* build/ && cp -R legacy/dist/assets build/ && cp ui/dist/static/css/*.css.map build/assets/css/ui.css.map && cp ui/dist/static/css/*.css build/assets/css/ui.css", | |||
There was a problem hiding this comment.
This seems like potentially undefined behaviour, which file is actually copied? It would be better to just use fixed names here.
There was a problem hiding this comment.
I've updated this to be to use the module name here e.g. ...css/main.*.css. Is that better?
squidsoup
reviewed
May 27, 2020
| @@ -1,61 +1,4 @@ | |||
| const webpack = require("webpack"); | |||
| const path = require("path"); | |||
| const { edit, remove, getPaths } = require("@rescripts/utilities"); | |||
There was a problem hiding this comment.
The @rescripts/utilities dependency can be dropped, although you may find it useful if we need to reconfigure mini-css-extract-plugin.
squidsoup
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
You may have to use
SKIP_PREFLIGHT_CHECK=true make uilike I did.Fixes
Fixes: #1157.